Subject: Re: [PATCH 2/3] ptp: add a software clock based on
 clock_monotonic_raw
From: john stultz <johnstul@us.ibm.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Torben Hohn <torbenh@gmx.de>, linux-kernel@vger.kernel.org,
        richard.cochran@omicron.at, tglx@linutronix.de
In-Reply-To: <20110304064639.GD3824@riccoc20.at.omicron.at>
References: <1299173174-348-1-git-send-email-torbenh@gmx.de>
	 <1299173174-348-3-git-send-email-torbenh@gmx.de>
	 <1299180844.28285.111.camel@work-vm>
	 <20110304064639.GD3824@riccoc20.at.omicron.at>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 05 Mar 2011 12:08:07 -0800
Message-ID: <1299355687.28285.130.camel@work-vm>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1364
Lines: 33

On Fri, 2011-03-04 at 07:46 +0100, Richard Cochran wrote:
> On Thu, Mar 03, 2011 at 11:34:04AM -0800, john stultz wrote:
> > On Thu, 2011-03-03 at 18:26 +0100, Torben Hohn wrote:
> > > First version of a software clock. Not very useful yet,
> > > as it doesnt generate events, but at least it allows
> > > for testing the ptp framework without special hardware.
> > 
> > So in the past, I pushed back on Richard for having something similar,
> > as I'm not psyched about duplicating interfaces. However, your
> > implementation is CLOCK_MONOTONIC_RAW instead of CLOCK_REALTIME and it
> > keeps the adjustments internal, I'm not as opposed.
> 
> (Aha! So it is okay after all ;)
> 
> I do think a software only PHC will make it easier for people to get
> started with the new interface. I have been carrying along such a
> patch privately for my own testing.

Consistency is but a hobgoblin... :)

But seriously, do forgive me if I misunderstood your earlier patches
with this respect. I thought it was just exporting CLOCK_REALTIME
directly through a new interface/clockid (which would be duplicative).

thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/