Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717Ab1CFOio (ORCPT ); Sun, 6 Mar 2011 09:38:44 -0500 Received: from ist.d-labs.de ([213.239.218.44]:40899 "EHLO mx01.d-labs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559Ab1CFOim convert rfc822-to-8bit (ORCPT ); Sun, 6 Mar 2011 09:38:42 -0500 Date: Sun, 6 Mar 2011 15:38:05 +0100 From: Florian Mickler To: Oliver Neukum Cc: mchehab@infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, "Greg Kroah-Hartman" , "Rafael J. Wysocki" , Maciej Rutecki Subject: Re: [PATCH] [media] dib0700: get rid of on-stack dma buffers Message-ID: <20110306153805.001011a9@schatten.dmk.lab> In-Reply-To: <201103061306.10045.oliver@neukum.org> References: <1299410212-24897-1-git-send-email-florian@mickler.org> <201103061306.10045.oliver@neukum.org> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1823 Lines: 50 On Sun, 6 Mar 2011 13:06:09 +0100 Oliver Neukum wrote: > Am Sonntag, 6. M?rz 2011, 12:16:52 schrieb Florian Mickler: > > This should fix warnings seen by some: > > WARNING: at lib/dma-debug.c:866 check_for_stack > > > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977. > > Reported-by: Zdenek Kabelac > > Signed-off-by: Florian Mickler > > CC: Mauro Carvalho Chehab > > CC: linux-media@vger.kernel.org > > CC: linux-kernel@vger.kernel.org > > CC: Greg Kroah-Hartman > > CC: Rafael J. Wysocki > > CC: Maciej Rutecki > > --- > > > > Please take a look at it, as I do not do that much kernel hacking > > and don't wanna brake anybodys computer... :) > > > > From my point of view this should _not_ go to stable even though it would > > be applicable. But if someone feels strongly about that and can > > take responsibility for that change... > > The patch looks good and is needed in stable. > It could be improved by using a buffer allocated once in the places > you hold a mutex anyway. > > Regards > Oliver Ok, I now put a buffer member in the priv dib0700_state which gets allocated on the heap. My patch introduces a new error condition in the dib0700_identify_state callback which gets not checked for in dvb_usb_find_device... Should we worry? Same for dib0700_get_version in the probe callback... But there, there was already the possibility of usb_control_msg returning an error... Regards, Flo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/