Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754968Ab1CGCHW (ORCPT ); Sun, 6 Mar 2011 21:07:22 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39863 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504Ab1CGCHV (ORCPT ); Sun, 6 Mar 2011 21:07:21 -0500 Date: Sun, 06 Mar 2011 18:07:58 -0800 (PST) Message-Id: <20110306.180758.226774711.davem@davemloft.net> To: geert@linux-m68k.org Cc: rdunlap@xenotime.net, j223yang@asset.uwaterloo.ca, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch] ariadne: fix possible null dereference From: David Miller In-Reply-To: References: <20110306070832.GA26188@asset.uwaterloo.ca> <20110306111141.9cc51306.rdunlap@xenotime.net> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 25 From: Geert Uytterhoeven Date: Sun, 6 Mar 2011 21:00:13 +0100 > On Sun, Mar 6, 2011 at 20:11, Randy Dunlap wrote: >> On Sun, 6 Mar 2011 02:08:32 -0500 j223yang@asset.uwaterloo.ca wrote: >> >>> Hi Randy, >>> I have tested my patch, and it is ok now. >>> Could you please try patching again? Sorry for previous trouble. >>> Thank you! >> >> Acked-by: Randy Dunlap > > Acked-by: Geert Uytterhoeven People really don't actually read patches, I think. Show me how dev can even be NULL here, it simply can't. So the correct fix is to remove the dev==NULL check altogether. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/