Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753099Ab1CFMLp (ORCPT ); Sun, 6 Mar 2011 07:11:45 -0500 Received: from smtp-out003.kontent.com ([81.88.40.217]:40859 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011Ab1CFMLn convert rfc822-to-8bit (ORCPT ); Sun, 6 Mar 2011 07:11:43 -0500 X-Greylist: delayed 352 seconds by postgrey-1.27 at vger.kernel.org; Sun, 06 Mar 2011 07:11:43 EST From: Oliver Neukum To: Florian Mickler Subject: Re: [PATCH] [media] dib0700: get rid of on-stack dma buffers Date: Sun, 6 Mar 2011 13:06:09 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc6-12-desktop+; KDE/4.4.4; x86_64; ; ) Cc: mchehab@infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, "Greg Kroah-Hartman" , "Rafael J. Wysocki" , Maciej Rutecki References: <1299410212-24897-1-git-send-email-florian@mickler.org> In-Reply-To: <1299410212-24897-1-git-send-email-florian@mickler.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Message-Id: <201103061306.10045.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1291 Lines: 33 Am Sonntag, 6. M?rz 2011, 12:16:52 schrieb Florian Mickler: > This should fix warnings seen by some: > WARNING: at lib/dma-debug.c:866 check_for_stack > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977. > Reported-by: Zdenek Kabelac > Signed-off-by: Florian Mickler > CC: Mauro Carvalho Chehab > CC: linux-media@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: Greg Kroah-Hartman > CC: Rafael J. Wysocki > CC: Maciej Rutecki > --- > > Please take a look at it, as I do not do that much kernel hacking > and don't wanna brake anybodys computer... :) > > From my point of view this should _not_ go to stable even though it would > be applicable. But if someone feels strongly about that and can > take responsibility for that change... The patch looks good and is needed in stable. It could be improved by using a buffer allocated once in the places you hold a mutex anyway. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/