Message-ID: <4D737B25.7090503@redhat.com>
Date: Sun, 06 Mar 2011 14:16:37 +0200
From: Avi Kivity <avi@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7
MIME-Version: 1.0
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
CC: Marcelo Tosatti <mtosatti@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 6/10] KVM: MMU: don not record gfn in kvm_mmu_pte_write
References: <4D70C569.1030107@cn.fujitsu.com> <4D70C630.1080100@cn.fujitsu.com> <4D737A96.6040409@redhat.com>
In-Reply-To: <4D737A96.6040409@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 831
Lines: 22

On 03/06/2011 02:14 PM, Avi Kivity wrote:
> On 03/04/2011 01:00 PM, Xiao Guangrong wrote:
>> No need to record the gfn to verifier the pte has the same mode as
>> current vcpu, it's because we only speculatively update the pte only
>> if the pte and vcpu have the same mode
>
> True.  We can, as an additional cleanup, change 
> mmu_pte_write_new_pte() to just do vcpu->arch.mmu.update_pte(...) 
> instead of the if ().
>

Also, we can remove the pfn guessing and to it in FNAME(update_pte), 
using gfn_to_pfn_atomic().

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/