Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753885Ab1CGPjf (ORCPT ); Mon, 7 Mar 2011 10:39:35 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:48819 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565Ab1CGPje (ORCPT ); Mon, 7 Mar 2011 10:39:34 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=A9nNicuNvyvZNG1VymU3DpzzlIoPXxxvsryYNzzxrRclOEfpRDXj2E9/oT+TCPll3w FycznkqBBWoYlXyYqEawmeK8GIikk5OK+jVrKjqHjkgwY/7BpamZ8cDekA4L9uwKu5/R Q+2dYc2Ofr18FXotKgydhP7JaFlgb5PAZJbO8= MIME-Version: 1.0 In-Reply-To: <1299350956-5614-1-git-send-email-cesarb@cesarb.net> References: <1299350956-5614-1-git-send-email-cesarb@cesarb.net> Date: Tue, 8 Mar 2011 00:39:34 +0900 Message-ID: Subject: Re: [PATCH] mm: remove inline from scan_swap_map From: Minchan Kim To: Cesar Eduardo Barros Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , KAMEZAWA Hiroyuki , Jens Axboe , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 23 On Sun, Mar 6, 2011 at 3:49 AM, Cesar Eduardo Barros wrote: > scan_swap_map is a large function (224 lines), with several loops and a > complex control flow involving several gotos. > > Given all that, it is a bit silly that is is marked as inline. The > compiler agrees with me: on a x86-64 compile, it did not inline the > function. > > Remove the "inline" and let the compiler decide instead. > > Signed-off-by: Cesar Eduardo Barros Reviewed-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/