DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=ieZrPL8JqaiqJSjBeh35IDVsOZnDbqouNa6mBk00owRLJNVtAkA9ARNO/EGocIXg1a
         2majWUC2iBC+gYsKqPSuVylSZS0XE0J94ScjQP4I6Dpr4My0WrctrNNyCLkRSPcfRNfH
         d5SV+JAUYnw2WoabaofRjNYcQ/wFLOMJLzUPg=
MIME-Version: 1.0
In-Reply-To: <20110307232655.GA7234@p183.telecom.by>
References: <201103072305.p27N5hKT000474@imap1.linux-foundation.org>
	<20110307232655.GA7234@p183.telecom.by>
Date: Tue, 8 Mar 2011 13:15:11 +0800
Message-ID: <AANLkTi=-PcbpBjWZuno1fjwZD-tGmC+JMxrzMr1FNwu7@mail.gmail.com>
Subject: Re: + sysctl-add-proc_dointvec_unsigned-handler.patch added to -mm tree
From: Dave Young <hidave.darkstar@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1139
Lines: 33

On Tue, Mar 8, 2011 at 7:26 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Mon, Mar 07, 2011 at 03:05:43PM -0800, akpm@linux-foundation.org wrote:
>> Add a proc_dointvec_unsigned() sysctl handler for positive value cases.
>
>> --- a/kernel/sysctl.c~sysctl-add-proc_dointvec_unsigned-handler
>> +++ a/kernel/sysctl.c
>
>> +int proc_dointvec_unsigned(struct ctl_table *table, int write,
>> +               void __user *buffer, size_t *lenp, loff_t *ppos)
>> +{
>> +     struct do_proc_dointvec_minmax_conv_param param = {
>> +             .min = &zero,
>> +     };
>> +     return do_proc_dointvec(table, write, buffer, lenp, ppos,
>> +                             do_proc_dointvec_minmax_conv, &param);
>> +}
>
> This silently ignored max value in .extra2 .

Hi,

Good cache, should set .max = NULL here

Thanks, will update this patch.

-- 
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/