Date: Tue, 8 Mar 2011 09:31:02 -0500
From: Vivek Goyal <vgoyal@redhat.com>
To: Justin TerAvest <teravest@google.com>
Cc: jaxboe@fusionio.com, ctalbott@google.com, guijianfeng@cn.fujitsu.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-cgroup: Lower minimum weight from 100 to 10.
Message-ID: <20110308143102.GC27455@redhat.com>
References: <1299538394-9669-1-git-send-email-teravest@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1299538394-9669-1-git-send-email-teravest@google.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1832
Lines: 50

On Mon, Mar 07, 2011 at 02:53:14PM -0800, Justin TerAvest wrote:
> We've found that we still get good, useful isolation at weights this
> low. I'd like to adjust the minimum so that any other changes can take
> these values into account.
> ---
>  Documentation/cgroups/blkio-controller.txt |    2 +-
>  block/blk-cgroup.h                         |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Looks good to me.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

> diff --git a/Documentation/cgroups/blkio-controller.txt b/Documentation/cgroups/blkio-controller.txt
> index 4ed7b5c..24314fd 100644
> --- a/Documentation/cgroups/blkio-controller.txt
> +++ b/Documentation/cgroups/blkio-controller.txt
> @@ -140,7 +140,7 @@ Proportional weight policy files
>  	- Specifies per cgroup weight. This is default weight of the group
>  	  on all the devices until and unless overridden by per device rule.
>  	  (See blkio.weight_device).
> -	  Currently allowed range of weights is from 100 to 1000.
> +	  Currently allowed range of weights is from 10 to 1000.
>  
>  - blkio.weight_device
>  	- One can specify per cgroup per device rules using this interface.
> diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h
> index ea4861b..57e7234 100644
> --- a/block/blk-cgroup.h
> +++ b/block/blk-cgroup.h
> @@ -240,7 +240,7 @@ static inline char *blkg_path(struct blkio_group *blkg) { return NULL; }
>  
>  #endif
>  
> -#define BLKIO_WEIGHT_MIN	100
> +#define BLKIO_WEIGHT_MIN	10
>  #define BLKIO_WEIGHT_MAX	1000
>  #define BLKIO_WEIGHT_DEFAULT	500
>  
> -- 
> 1.7.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/