Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755841Ab1CHWlp (ORCPT ); Tue, 8 Mar 2011 17:41:45 -0500 Received: from out5.smtp.messagingengine.com ([66.111.4.29]:43991 "EHLO out5.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337Ab1CHWlo (ORCPT ); Tue, 8 Mar 2011 17:41:44 -0500 X-Greylist: delayed 549 seconds by postgrey-1.27 at vger.kernel.org; Tue, 08 Mar 2011 17:41:44 EST Message-Id: <1299623554.6915.1427615977@webmail.messagingengine.com> X-Sasl-Enc: g2+MkZIF0lahy3mPJT1ocp8JyCjijCkECf1gQwDTJE8C 1299623554 From: "Alexander van Heukelum" To: "Sedat Dilek" Cc: "Sedat Dilek" , "H.J. Lu" , "Len Brown" , "Pavel Machek" , "Rafael J. Wysocki" , "Thomas Gleixner" , "Ingo Molnar" , "H. Peter Anvin" , x86@kernel.org, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii" X-Mailer: MessagingEngine.com Webmail Interface References: <1299620364-21644-1-git-send-email-sedat.dilek@gmail.com> Subject: Re: [PATCH] x86: Fix ACPI wakeup build failure In-Reply-To: <1299620364-21644-1-git-send-email-sedat.dilek@gmail.com> Date: Tue, 08 Mar 2011 23:32:34 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2155 Lines: 59 On Tue, 08 Mar 2011 22:39 +0100, "Sedat Dilek" wrote: > This fixes the following breakage in linux-next (next-20110308): > AS arch/x86/kernel/acpi/wakeup_rm.o > arch/x86/kernel/acpi/wakeup_rm.S: Assembler messages: > arch/x86/kernel/acpi/wakeup_rm.S:12: Error: .size expression with > symbol `wakeup_code_start' does not evaluate to a constant > > The issue was introduced by commit > d1ee433539ea5963a8f946f3428b335d1c5fdb20: > "x86, trampoline: Use the unified trampoline setup for ACPI wakeup" > > The problem was discovered while using Debian's binutils > (2.21.0.20110302-1) > and experimenting with binutils from upstream. > > Thanks Alexander and H.J. for the vital help. > > CC: Alexander van Heukelum > CC: "H.J. Lu" > CC: Len Brown > CC: Pavel Machek > CC: "Rafael J. Wysocki" > CC: Thomas Gleixner > CC: Ingo Molnar > CC: "H. Peter Anvin" > CC: x86@kernel.org > CC: linux-pm@lists.linux-foundation.org > CC: linux-kernel@vger.kernel.org > CC: linux-next@vger.kernel.org > Signed-off-by: Sedat Dilek Acked-by: Alexander van Heukelum (This problem exists in the x86-tree. Mainline is fine.) > --- > arch/x86/kernel/acpi/wakeup_rm.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/acpi/wakeup_rm.S > b/arch/x86/kernel/acpi/wakeup_rm.S > index 6ce81ee..63b8ab5 100644 > --- a/arch/x86/kernel/acpi/wakeup_rm.S > +++ b/arch/x86/kernel/acpi/wakeup_rm.S > @@ -9,4 +9,4 @@ > .globl acpi_wakeup_code > acpi_wakeup_code: > .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin" > - .size wakeup_code_start, .-wakeup_code_start > + .size acpi_wakeup_code, .-acpi_wakeup_code > -- > 1.7.4.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/