Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756705Ab1CHXah (ORCPT ); Tue, 8 Mar 2011 18:30:37 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:60463 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756665Ab1CHXa0 (ORCPT ); Tue, 8 Mar 2011 18:30:26 -0500 Date: Tue, 8 Mar 2011 23:30:45 +0000 From: Mark Brown To: adharmap@codeaurora.org Cc: davidb@codeaurora.org, "David S. Miller" , Andrew Morton , Bryan Huntsman , Daniel Walker , David Collins , Grant Likely , Greg Kroah-Hartman , Joe Perches , Russell King , Samuel Ortiz , Stepan Moskovchenko , Linus Walleij , Thomas Glexiner , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Qualcomm PM8921 MFD v2 4/6] mfd: pm8xxx-mpp: Add pm8xxx MPP driver Message-ID: <20110308233045.GB2717@opensource.wolfsonmicro.com> References: <1299564590-30116-1-git-send-email-adharmap@codeaurora.org> <1299564590-30116-5-git-send-email-adharmap@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1299564590-30116-5-git-send-email-adharmap@codeaurora.org> X-Cookie: Long life is in store for you. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 24 On Mon, Mar 07, 2011 at 10:09:48PM -0800, adharmap@codeaurora.org wrote: > + mpp_chip->gpio_chip.label = PM8XXX_MPP_DEV_NAME; > + mpp_chip->gpio_chip.direction_input = pm8xxx_mpp_dir_input; > + mpp_chip->gpio_chip.direction_output = pm8xxx_mpp_dir_output; > + mpp_chip->gpio_chip.to_irq = pm8xxx_mpp_to_irq; > + mpp_chip->gpio_chip.get = pm8xxx_mpp_get; > + mpp_chip->gpio_chip.set = pm8xxx_mpp_set; > + mpp_chip->gpio_chip.dbg_show = pm8xxx_mpp_dbg_show; > + mpp_chip->gpio_chip.ngpio = pdata->core_data.nmpps; > + mpp_chip->gpio_chip.can_sleep = 1; > + mpp_chip->gpio_chip.dev = &pdev->dev; > + mpp_chip->gpio_chip.base = pdata->mpp_base; It's seems really odd that you're adding gpiolib stuff here when you've also got a separate gpiolib driver. Possibly this all shouldn't actually be split up as much as it is - there's also the issue with the gpiolib driver needing to peer into the interrupt controller. It might simplify the code if things were merged more. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/