Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sat, 13 Jul 2002 13:51:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sat, 13 Jul 2002 13:51:42 -0400 Received: from leibniz.math.psu.edu ([146.186.130.2]:50152 "EHLO math.psu.edu") by vger.kernel.org with ESMTP id ; Sat, 13 Jul 2002 13:51:41 -0400 Date: Sat, 13 Jul 2002 13:54:29 -0400 (EDT) From: Alexander Viro To: Paul Menage cc: LKML , lse-tech Subject: Re: [Lse-tech] Re: [RFC] dcache scalability patch (2.4.17) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 32 On Sat, 13 Jul 2002, Alexander Viro wrote: > > > On Sat, 13 Jul 2002, Paul Menage wrote: > > > - accessing foo/../bar, won't mark foo as referenced, even though it > > might be being referenced frequently. Probably not a common case for foo > > to be accessed exclusively in this way, but it could be fixed by marking > > a dentry referenced when following ".." > > It certainly will. Look - until ->d_count hits zero referenced bit is > not touched or looked at. At all. > > Look at the code. There is _no_ aging for dentries with positive ->d_count. > They start aging only when after they enter unused_list... On the second thought, I should apply that advice myself. It's true that they start aging only after they hit the unused list, but they are born old. Hrm... OK, it kills that variant and it really looks like there's no way around dirtying dentry first time we find it on d_lookup(). Which means that we probably want to put that |= under if - without any ifdefs... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/