Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177Ab1CICBw (ORCPT ); Tue, 8 Mar 2011 21:01:52 -0500 Received: from mga03.intel.com ([143.182.124.21]:7155 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932158Ab1CICBr (ORCPT ); Tue, 8 Mar 2011 21:01:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.62,287,1297065600"; d="scan'208";a="399737490" Date: Wed, 9 Mar 2011 10:01:31 +0800 From: Yuanhan Liu To: Steven Rostedt Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, Ingo Molnar , Frederic Weisbecker , Rusty Russell , chris Subject: Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters Message-ID: <20110309020131.GA19224@yliu-dev.sh.intel.com> References: <1299622684.20306.77.camel@gandalf.stny.rr.com> <20110308232258.GA25987@Krystal> <1299627175.20306.96.camel@gandalf.stny.rr.com> <20110309000753.GA27729@Krystal> <1299629657.20306.105.camel@gandalf.stny.rr.com> <20110309002921.GA744@Krystal> <1299631924.20306.122.camel@gandalf.stny.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1299631924.20306.122.camel@gandalf.stny.rr.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 42 On Tue, Mar 08, 2011 at 07:52:04PM -0500, Steven Rostedt wrote: > On Tue, 2011-03-08 at 19:29 -0500, Mathieu Desnoyers wrote: > > * Steven Rostedt (rostedt@goodmis.org) wrote: > > > On Tue, 2011-03-08 at 19:07 -0500, Mathieu Desnoyers wrote: [snip] > > > > > > > > If you want to enable a tracepoint on module load simply do: > > > > > > modprobe mymod trace_my_tracepoint=1 > > > > > > Otherwise modify your modprobe.d directory. This is the way users have > > > been doing module parameters for years. > > > > > > That's pretty simple to me. > > > > Everything is always so much easier when your end-user target is yourself. > > What are users for anyway ? :-P > > Users are for testing code ;) As another end-user, this looks fine (also simple) to me ;) > > But that's a good question. As I wrote this because I'm purging my inbox > and came across Yuanhan Liu's patch set. I'm curios to what Yuanhan's > motivation for this change was. The motivation of my original patch is simple: try to not miss any trace events. I guess it's a kind of feature that trace(or module) should have ;) Thanks, Yuanhan Liu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/