Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932183Ab1CIKic (ORCPT ); Wed, 9 Mar 2011 05:38:32 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:38411 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757138Ab1CIKib (ORCPT ); Wed, 9 Mar 2011 05:38:31 -0500 Date: Wed, 9 Mar 2011 05:38:28 -0500 From: "hch@infradead.org" To: Jens Axboe Cc: "hch@infradead.org" , Vivek Goyal , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 07/10] fs: make generic file read/write functions plug Message-ID: <20110309103828.GA26181@infradead.org> References: <1295659049-2688-1-git-send-email-jaxboe@fusionio.com> <1295659049-2688-8-git-send-email-jaxboe@fusionio.com> <20110304040907.GB32404@redhat.com> <4D70E78D.9000402@fusionio.com> <20110304132551.GA2407@infradead.org> <4D762330.8000003@fusionio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D762330.8000003@fusionio.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 19 On Tue, Mar 08, 2011 at 01:38:08PM +0100, Jens Axboe wrote: > -#define DP_UNPLUG 8 /* equals REQ_UNPLUG */ > +#define DP_UNPLUG 8 /* not used anymore */ The way this is used might need some more review. It seems like DRBD is trying to propagate unplug requests over the wire, which is functionality we lose now. > + * The various wait functions, such as wait_on_writeback_range() will > + * ultimately call sync_page() which will ultimately call > + * blk_run_backing_dev(), which will end up unplugging the device queue. This comment describes code that doesn't exist anymore on your branch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/