Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932747Ab1CIOGb (ORCPT ); Wed, 9 Mar 2011 09:06:31 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:53824 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932671Ab1CIOG2 (ORCPT ); Wed, 9 Mar 2011 09:06:28 -0500 Date: Wed, 9 Mar 2011 11:06:10 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@elte.hu, linux-kernel@vger.kernel.org, phan@redhat.com Subject: Re: [PATCH 1/2] perf,top: fix events overflow in top command Message-ID: <20110309140610.GB20188@ghostprotocols.net> References: <1299528821-17521-1-git-send-email-jolsa@redhat.com> <1299528821-17521-2-git-send-email-jolsa@redhat.com> <20110309135925.GA20188@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110309135925.GA20188@ghostprotocols.net> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1180 Lines: 28 Em Wed, Mar 09, 2011 at 10:59:25AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Mar 07, 2011 at 09:13:40PM +0100, Jiri Olsa escreveu: > > The snprintf function returns number of printed characters even > > if it cross the size parameter. So passing enough events via '-e' > > parameter will cause segmentation fault. > > > > It's reproduced by following command: > > > > perf top -e `perf list | grep Tracepoint | awk -F'[' '\ > > {gsub(/[[:space:]]+/,"",$1);array[FNR]=$1}END{outputs=array[1];\ > > for (i=2;i<=FNR;i++){ outputs=outputs "," array[i];};print outputs}'` > > > > Attached patch is adding SNPRINTF macro that provides the > > overflow check and returns actuall number of printed characters. > > Good catch, applying to perf/urgent. Tried but it doesn't apply nor can I reproduce the overflow (albeit granted the long line of events is annoying). So I'm applying both patches to perf/core instead. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/