Date: Wed, 9 Mar 2011 08:36:09 -0600
From: scameron@beardog.cce.hp.com
To: =?iso-8859-1?Q?Am=E9rico?= Wang <xiyou.wangcong@gmail.com>
Cc: james.bottomley@hansenpartnership.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, smcameron@yahoo.com, thenzl@redhat.com,
        akpm@linux-foundation.org, mikem@beardog.cce.hp.com
Subject: Re: [PATCH 2/2] hpsa: export resettable_on_kexec host attribute
Message-ID: <20110309143609.GG12760@beardog.cce.hp.com>
References: <20110308230749.22291.56200.stgit@beardog.cce.hp.com> <20110308231003.22291.20417.stgit@beardog.cce.hp.com> <20110309063339.GB16951@cr0.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20110309063339.GB16951@cr0.redhat.com>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1478
Lines: 33

On Wed, Mar 09, 2011 at 02:33:39PM +0800, Am?rico Wang wrote:
> On Tue, Mar 08, 2011 at 05:10:03PM -0600, Stephen M. Cameron wrote:
> >From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> >
> >This attribute, requested by Redhat, allows kexec-tools to know
> >whether the controller can honor the reset_devices kernel parameter
> >and actually reset the controller.  For kdump to work properly it
> >is necessary that the reset_devices parameter be honored.  This
> >attribute enables kexec-tools to warn the user if they attempt to
> >designate a non-resettable controller as the dump device.
> >
> >Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> 
> Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
> 
> Maybe we should docment this sysfs attribute somewhere?

Yes, thanks.  

Perhaps in Documentation/ABI/testing/sysfs-bus-scsi-devices-hpsa
(which doesn't exist) and/or in Documentation/scsi/hpsa.txt (which does exist, and
is where other hpsa specific sysfs attributes are documented.)  Probably so
as not to duplicate things, the latter.  Or maybe what documentation of
sysfs things that is currently in hpsa.txt should be moved to Documentation/ABI/...
and a reference to it put in hpsa.txt?

-- steve
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/