Date: Wed, 09 Mar 2011 14:17:29 -0800 (PST)
Message-Id: <20110309.141729.35046292.davem@davemloft.net>
To: tj@kernel.org
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, kay.sievers@vrfy.org,
        hch@infradead.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 04/16] ide: Convert to bdops->check_events()
From: David Miller <davem@davemloft.net>
In-Reply-To: <1299662016-7721-5-git-send-email-tj@kernel.org>
References: <1299662016-7721-1-git-send-email-tj@kernel.org>
	<1299662016-7721-5-git-send-email-tj@kernel.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1103
Lines: 25

From: Tejun Heo <tj@kernel.org>
Date: Wed,  9 Mar 2011 10:13:24 +0100

> Convert ->media_changed() to the new ->check_events() method.  The
> conversion is mostly mechanical.  The only notable change is that
> cdrom now doesn't generate any event if @slot_nr isn't CDSL_CURRENT.
> It used to return -EINVAL which would be treated as media changed.  As
> media changer isn't supported anyway, this doesn't make any
> difference.
> 
> This makes ide emit the standard disk events and allows kernel event
> polling.  Currently, only MEDIA_CHANGE event is implemented.  Adding
> support for EJECT_REQUEST shouldn't be difficult; however, given that
> ide driver is already deprecated, it probably is best to leave it
> alone.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Acked-by: Jens Axboe <axboe@kernel.dk>

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/