Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937Ab1CJQIg (ORCPT ); Thu, 10 Mar 2011 11:08:36 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:56699 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934Ab1CJQId (ORCPT ); Thu, 10 Mar 2011 11:08:33 -0500 X-IronPort-AV: E=Sophos;i="4.62,296,1297054800"; d="scan'208";a="139621104" From: Ian Campbell To: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org Cc: Konrad Rzeszutek Wilk , Jeremy Fitzhardinge , Stefano Stabellini , Ian Campbell Subject: [PATCH 03/14] xen: events: simplify comment Date: Thu, 10 Mar 2011 16:08:04 +0000 Message-Id: <1299773295-348-3-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <1299773279.17339.813.camel@zakaz.uk.xensource.com> References: <1299773279.17339.813.camel@zakaz.uk.xensource.com> X-OriginalArrivalTime: 10 Mar 2011 16:08:22.0229 (UTC) FILETIME=[60EC5050:01CBDF3D] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2200 Lines: 54 It is never valid assume any particular relationship between a Xen PIRQ number and and Linux IRQ number so there is no need to hedge when saying so. Signed-off-by: Ian Campbell --- drivers/xen/events.c | 10 +++------- include/xen/events.h | 4 +--- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 2ce95a6..a9c154d 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -583,13 +583,9 @@ int xen_allocate_pirq(unsigned gsi, int shareable, char *name) return xen_map_pirq_gsi(gsi, gsi, shareable, name); } -/* xen_map_pirq_gsi might allocate irqs from the top down, as a - * consequence don't assume that the irq number returned has a low value - * or can be used as a pirq number unless you know otherwise. - * - * One notable exception is when xen_map_pirq_gsi is called passing an - * hardware gsi as argument, in that case the irq number returned - * matches the gsi number passed as second argument. +/* + * Do not make any assumptions regarding the relationship between the + * IRQ number returned here and the Xen pirq argument. * * Note: We don't assign an event channel until the irq actually started * up. Return an existing irq if we've already got one for the gsi. diff --git a/include/xen/events.h b/include/xen/events.h index 962da2c..f6fed94 100644 --- a/include/xen/events.h +++ b/include/xen/events.h @@ -68,9 +68,7 @@ int xen_set_callback_via(uint64_t via); void xen_evtchn_do_upcall(struct pt_regs *regs); void xen_hvm_evtchn_do_upcall(void); -/* Allocate an irq for a physical interrupt, given a gsi. "Legacy" - * GSIs are identity mapped; others are dynamically allocated as - * usual. */ +/* Allocate an irq for a physical interrupt, given a gsi. */ int xen_allocate_pirq(unsigned gsi, int shareable, char *name); int xen_map_pirq_gsi(unsigned pirq, unsigned gsi, int shareable, char *name); -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/