Date: Thu, 10 Mar 2011 11:54:52 -0500
From: Vivek Goyal <vgoyal@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: jaxboe@fusionio.com, linux-kernel@vger.kernel.org, hch@infradead.org,
        Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH 04/10] block: initial patch for on-stack per-task plugging
Message-ID: <20110310165452.GE29464@redhat.com>
References: <1295659049-2688-1-git-send-email-jaxboe@fusionio.com>
 <1295659049-2688-5-git-send-email-jaxboe@fusionio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1295659049-2688-5-git-send-email-jaxboe@fusionio.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 841
Lines: 26

On Sat, Jan 22, 2011 at 01:17:23AM +0000, Jens Axboe wrote:

[..]
> -/*
> - * Only disabling plugging for non-rotational devices if it does tagging
> - * as well, otherwise we do need the proper merging
> - */
> -static inline bool queue_should_plug(struct request_queue *q)
> -{
> -	return !(blk_queue_nonrot(q) && blk_queue_tagged(q));
> -}
> -

Jens,

While discussing stack plug with Mike Snitzer, this occurred to us that in
new code we seem to be plugging even if underlying device is SSD with NCQ.
Should we continue to maintain the old behavior of not plugging for NCQ SSD?

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/