Message-ID: <4D792735.8000604@fusionio.com>
Date: Thu, 10 Mar 2011 20:32:05 +0100
From: Jens Axboe <jaxboe@fusionio.com>
MIME-Version: 1.0
To: Vivek Goyal <vgoyal@redhat.com>
CC: Jens Axboe <axboe@kernel.dk>, <linux-kernel@vger.kernel.org>,
        <hch@infradead.org>, Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH 04/10] block: initial patch for on-stack per-task plugging
References: <1295659049-2688-1-git-send-email-jaxboe@fusionio.com> <1295659049-2688-5-git-send-email-jaxboe@fusionio.com> <20110310165452.GE29464@redhat.com>
In-Reply-To: <20110310165452.GE29464@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1316
Lines: 38

On 2011-03-10 17:54, Vivek Goyal wrote:
> On Sat, Jan 22, 2011 at 01:17:23AM +0000, Jens Axboe wrote:
> 
> [..]
>> -/*
>> - * Only disabling plugging for non-rotational devices if it does tagging
>> - * as well, otherwise we do need the proper merging
>> - */
>> -static inline bool queue_should_plug(struct request_queue *q)
>> -{
>> -	return !(blk_queue_nonrot(q) && blk_queue_tagged(q));
>> -}
>> -
> 
> Jens,
> 
> While discussing stack plug with Mike Snitzer, this occurred to us that in
> new code we seem to be plugging even if underlying device is SSD with NCQ.
> Should we continue to maintain the old behavior of not plugging for NCQ SSD?

The main reason plugging was turned off for SSD's previously was because
it ended up hammering on the queue lock a lot. So it was turned off to
speed them up.

The new plugging scheme is faster than hitting the queue directly, so
now it would be a good idea to do the plugging in fact. Plus even for
high performance SSD's, things like merging are still a good idea.

So yes, it's on now and on purpose.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/