Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914Ab1CJThP (ORCPT ); Thu, 10 Mar 2011 14:37:15 -0500 Received: from home.keithp.com ([63.227.221.253]:39645 "EHLO keithp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411Ab1CJThN (ORCPT ); Thu, 10 Mar 2011 14:37:13 -0500 From: Keith Packard To: Takashi Iwai , Indan Zupancic Cc: Linux Kernel Mailing List , DRI mailing list , Alex Riesen , Tino Keitel , Linus Torvalds , stable@kernel.org Subject: Re: [PATCH] drm/i915: Revive combination mode for backlight control In-Reply-To: References: <20110216192658.GA7225@blimp.localdomain> <20110217221329.GA3332@x61.home> <3f792aaf90cf0b3d49be21baa2682d5d.squirrel@webmail.greenhost.nl> <20110222130440.21a27714@jbarnes-desktop> <20110222223120.GA3567@x61.home> <3e6f092bd0aa54fd6b9eb524f6c87ecf.squirrel@webmail.greenhost.nl> <1a06e2711df021a802d609ad1a75db17.squirrel@webmail.greenhost.nl> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Thu, 10 Mar 2011 11:36:51 -0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 53 --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 10 Mar 2011 14:02:12 +0100, Takashi Iwai wrote: > This reverts commit 951f3512dba5bd44cda3e5ee22b4b522e4bb09fb >=20 > drm/i915: Do not handle backlight combination mode specially >=20 > since this commit introduced other regressions due to untouched LBPC > register, e.g. the backlight dimmed after resume. >=20 > In addition to the revert, this patch includes a fix for the original > issue (weird backlight levels) by removing the wrong bit shift for > computing the current backlight level. > Also, including typo fixes (lpbc -> lbpc). >=20 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D34524 > Acked-by: Indan Zupancic > Cc: > Signed-off-by: Takashi Iwai This looks good, and ensures that LBPC ranges from 0 - 0xfe as required. The one thing we want is a comment that explains > + val &=3D ~1; The reason for this is that some ancient platforms wire this bit to be "go to max backlight", or at least that's why this was in the 2D driver from which this code was derived. Reviewed-by: Keith Packard Reviewed-by: Jesse Barnes =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFNeShTQp8BWwlsTdMRArtPAKCvLOuseWRkdIEHb5ncDMVFjAlIFQCfcnSK UnIpAwX0o3OTEVIWr7xmxiQ= =+uEn -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/