Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753063Ab1CJWPa (ORCPT ); Thu, 10 Mar 2011 17:15:30 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:53028 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455Ab1CJWP2 (ORCPT ); Thu, 10 Mar 2011 17:15:28 -0500 Date: Thu, 10 Mar 2011 14:16:05 -0800 (PST) Message-Id: <20110310.141605.189705143.davem@davemloft.net> To: hagen@jauu.net Cc: sledz@dresearch.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, m.schuknecht@dresearch.de Subject: Re: [PATCH v3] tcp: ioctl type SIOCOUTQNSD returns amount of data not sent From: David Miller In-Reply-To: <20110310221205.GF3121@nuttenaction> References: <1299441595-18455-1-git-send-email-sledz@dresearch.de> <20110309.140951.232741403.davem@davemloft.net> <20110310221205.GF3121@nuttenaction> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1245 Lines: 33 From: Hagen Paul Pfeifer Date: Thu, 10 Mar 2011 23:12:05 +0100 > * David Miller | 2011-03-09 14:09:51 [-0800]: > >>From: Steffen Sledz >>Date: Sun, 6 Mar 2011 20:59:55 +0100 >> >>> From: Mario Schuknecht >>> >>> In contrast to SIOCOUTQ which returns the amount of data sent >>> but not yet acknowledged plus data not yet sent this patch only >>> returns the data not sent. >>> >>> For various methods of live streaming bitrate control it may >>> be helpful to know how much data are in the tcp outqueue are >>> not sent yet. >>> >>> Signed-off-by: Mario Schuknecht >>> Signed-off-by: Steffen Sledz >> >>Applied, thanks. > > A little bit late - but why not using struct tcp_info for that? The > information is already provided via getsockopt(TCP_INFO). It's pretty heavy handed to copy that entire TCP_INFO struct into userspace during every I/O sequence the application makes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/