Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754156Ab1CJXnJ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Mar 2011 18:43:09 -0500
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:54912 "EHLO
	hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753349Ab1CJXnI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Mar 2011 18:43:08 -0500
X-Authority-Analysis: v=1.1 cv=UQuFHoD2CPQ248x8AXEbKhr4z9AaDqApxmEl3BhfZ64= c=1 sm=0 a=UwRGqXM3h7MA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=nAlSVcmetruQe748CxIA:9 a=7LKaExPbMT6rYpEyXxEA:7 a=HjLumo7wrGxOa7AgKN1lMp9ae00A:4 a=PUjeQqilurYA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117
X-Cloudmark-Score: 0
X-Originating-IP: 67.242.120.143
Subject: Re: [PATCH 0/2] jump label: update for .39
From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: David Daney <ddaney@caviumnetworks.com>,
        Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
        Jason Baron <jbaron@redhat.com>, peterz@infradead.org, hpa@zytor.com,
        mingo@elte.hu, andi@firstfloor.org, roland@redhat.com, rth@redhat.com,
        masami.hiramatsu.pt@hitachi.com, fweisbec@gmail.com, avi@redhat.com,
        davem@davemloft.net, sam@ravnborg.org, michael@ellerman.id.au,
        linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>
In-Reply-To: <alpine.LFD.2.00.1103110029090.2787@localhost6.localdomain6>
References: <1299780241.15854.393.camel@gandalf.stny.rr.com>
	 <20110310182000.GB2906@redhat.com>
	 <1299782143.15854.402.camel@gandalf.stny.rr.com>
	 <4D791CAA.7090108@caviumnetworks.com>
	 <1299783236.15854.405.camel@gandalf.stny.rr.com>
	 <4D791F31.6040100@caviumnetworks.com>
	 <1299785143.15854.407.camel@gandalf.stny.rr.com>
	 <1299786329.15854.409.camel@gandalf.stny.rr.com>
	 <BLU0-SMTP311155BEBE5F141636A6E596C80@phx.gbl>
	 <1299793339.15854.430.camel@gandalf.stny.rr.com>
	 <BLU0-SMTP101D168109508CC1B82F0E496C80@phx.gbl>
	 <1299798970.15854.484.camel@gandalf.stny.rr.com>
	 <4D795DCE.7050807@caviumnetworks.com>
	 <alpine.LFD.2.00.1103110029090.2787@localhost6.localdomain6>
Content-Type: text/plain; charset="ISO-8859-15"
Date: Thu, 10 Mar 2011 18:43:04 -0500
Message-ID: <1299800584.15854.520.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 958
Lines: 34

On Fri, 2011-03-11 at 00:32 +0100, Thomas Gleixner wrote:

> > It should work, but it hurts my eyes to see the source code forcing a 64-bit
> > word to 32-bit alignment.
> 
> We solved such stuff with macros in other places already.
> 
> #ifdef 64bit
> # define BLA 8
> #else
> # define BLA 4
> #endif
> 
> and then use 
> 
> .aling BLA
> 
> Where is the problem?

That's basically the solution that Jason came up with, and what I
expected. What caught my eye was that David Miller had .align 4 for this
on sparc which is the one arch that is truly picky about such things. As
I understood more about this, I see that would work for both archs.

That doesn't mean I'm against the .align BLA solution.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/