Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754246Ab1CKAJS (ORCPT ); Thu, 10 Mar 2011 19:09:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24015 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754112Ab1CKAJR (ORCPT ); Thu, 10 Mar 2011 19:09:17 -0500 Date: Fri, 11 Mar 2011 00:09:01 +0000 From: Dr Andrew John Hughes To: Marc Kleine-Budde Cc: linux-kernel@vger.kernel.org, stable@kernel.org, Trond.Myklebust@netapp.com Subject: Re: NFS regression in 2.6.37.1 (current stable) Message-ID: <20110311000901.GC22030@rivendell.middle-earth.co.uk> References: <20110310185321.GA22030@rivendell.middle-earth.co.uk> <4D791FA3.3070100@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D791FA3.3070100@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2868 Lines: 71 On 19:59 Thu 10 Mar , Marc Kleine-Budde wrote: > Hello Andrew, > > On 03/10/2011 07:53 PM, Dr Andrew John Hughes wrote: > > [Please CC me on responses as I'm not subscribed] > > > > Hi, > > > > I seem to have uncovered a regression in the NFS code between 2.6.37 and 2.6.37.1 > > caused by this changeset: > > > > commit 55ea499d60aefa3d03a77fc8590c26b5881faa92 > > Author: Trond Myklebust > > Date: Sat Jan 8 17:45:38 2011 -0500 > > NFS: Don't use vm_map_ram() in readdir > > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.37.y.git;a=commit;h=6650239a4b01077e80d5a4468562756d77afaa59 > > > > With this change applied, copying of files between NFS and non-NFS > > mounts seems to be broken. The easiest way I've found to replicate > > this myself is to use a VCS to do a clone of a tree on a NFS mount to > > a directory on a non-NFS mount. I used Mercurial, as I had Mercurial > > trees to hand from work on IcedTea, but I assume doing it with a git > > tree such as the linux tree would also work. The idea is to do > > something which involves copying over a bunch of directories and > > checking the result is readable. > > > > $ hg clone $HOME/projects/openjdk/icedtea6-hg > > destination directory: icedtea6-hg > > updating to branch default > > abort: > > data/contrib/templater/hotspot/src/cpu/CPU/vm/bytecodeInterpreter_CPU.inline.hpp.i@16d04ce16287: > > no match found! > > > > In the above, $HOME is an NFS mount and $PWD is a local reiserfs > > partition. I initially hit failures doing builds with source on $HOME > > and the build directory on a local reiserfs partition. In that > > scenario, it would fail as not being able to find files that should > > have been copied over. > > > > Reverting the changeset fixes the issue. 2.6.37.2 still has the bug. > > I haven't checked 2.6.37.3 yet but I didn't see any NFS changes in there. > > Which arch are you using? As this patch is also part of the upcoming > 2.6.38, can you check if the latest .38 is affected, too? > Sorry, I should have said; it's x86_64. I'll give .38 a go. It sounds, from the other responses, like that has the required fix and it just needs to be backported to the 2.6.37 tree. > cheers, Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | > Cheers, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/