Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372Ab1CKHXm (ORCPT ); Fri, 11 Mar 2011 02:23:42 -0500 Received: from cantor.suse.de ([195.135.220.2]:42335 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181Ab1CKHXl (ORCPT ); Fri, 11 Mar 2011 02:23:41 -0500 Date: Fri, 11 Mar 2011 08:23:40 +0100 Message-ID: From: Takashi Iwai To: "Indan Zupancic" Cc: "Keith Packard" , "Linus Torvalds" , "Jesse Barnes" , "DRI mailing list" , "Chris Wilson" , "Linux Kernel Mailing List" Subject: Re: drm/i915: Fix DPMS and suspend interaction for intel_panel.c In-Reply-To: <5e60ae646a15c73f5be0c309f51d1c63.squirrel@webmail.greenhost.nl> References: <5e60ae646a15c73f5be0c309f51d1c63.squirrel@webmail.greenhost.nl> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 36 [Removed stable-kernel from Cc] At Fri, 11 Mar 2011 02:35:45 +0100 (CET), Indan Zupancic wrote: > > drm/i915: Fix DPMS and suspend interaction for intel_panel.c > > When suspending intel_panel_disable_backlight() is never called, > but intel_panel_enable_backlight() is called at resume. With the > effect that if the brightness was ever changed after screen > blanking, the wrong brightness gets restored at resume time. > > Nothing guarantees that those calls will be balanced, so having > backlight_enabled makes no sense, as the real state can change > without the panel code noticing. So keep things as stateless as > possible. > > Signed-off-by: Indan Zupancic Indan, when you need a patch to be added to stable kernel, just put Cc to stable kernel around your sign-off line. Then Greg will pick it up automatically once when the patch is merged to Linus tree. Anyway, the patch looks good to me. A nice clean-up. Reviewed-by: Takashi Iwai thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/