Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413Ab1CKJI0 (ORCPT ); Fri, 11 Mar 2011 04:08:26 -0500 Received: from smarthost1.greenhost.nl ([195.190.28.78]:55801 "EHLO smarthost1.greenhost.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581Ab1CKJIX (ORCPT ); Fri, 11 Mar 2011 04:08:23 -0500 Message-ID: <6137e754bd8453a60f892b0f03663352.squirrel@webmail.greenhost.nl> In-Reply-To: References: <20110216192658.GA7225@blimp.localdomain> <20110217221329.GA3332@x61.home> <3f792aaf90cf0b3d49be21baa2682d5d.squirrel@webmail.greenhost.nl> <20110222130440.21a27714@jbarnes-desktop> <20110222223120.GA3567@x61.home> <3e6f092bd0aa54fd6b9eb524f6c87ecf.squirrel@webmail.greenhost.nl> <1a06e2711df021a802d609ad1a75db17.squirrel@webmail.greenhost.nl> <334e13a8513c5863dc9a5d278831777f.squirrel@webmail.greenhost.nl> Date: Fri, 11 Mar 2011 10:08:21 +0100 (CET) Subject: Re: [PATCH] drm/i915: Revive combination mode for backlight control From: "Indan Zupancic" To: "Takashi Iwai" Cc: "Linus Torvalds" , "Alex Riesen" , "Jesse Barnes" , "DRI mailing list" , "Chris Wilson" , "Linux Kernel Mailing List" , "Tino Keitel" , stable@kernel.org User-Agent: SquirrelMail/1.4.17 MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: 0.1 X-Scan-Signature: 71684ae416b12bc74806129cb02de027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 29 On Fri, March 11, 2011 08:26, Takashi Iwai wrote: > At Fri, 11 Mar 2011 02:23:08 +0100 (CET), > Indan Zupancic wrote: >> >> Hi, >> >> Some nitpicks below. I know you're just restoring the original code, >> but if we improve it we can as well do it now. > > Well, Linus already merged my patch quickly. So, we can improve the > readability as an additional patch, but I think it's likely a 2.6.39 > material. > > All you comments below look reasonable. Could you send a new patch? Well, my main concern was the slightly incorrect commit message, but oh well, too late for that now. I'll probably send a patch after 2.6.38 is released. Greetings, Indan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/