Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752939Ab1CKSFZ (ORCPT ); Fri, 11 Mar 2011 13:05:25 -0500 Received: from na3sys009aog105.obsmtp.com ([74.125.149.75]:59588 "EHLO na3sys009aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465Ab1CKSFX (ORCPT ); Fri, 11 Mar 2011 13:05:23 -0500 MIME-Version: 1.0 In-Reply-To: References: <1299864633-27542-1-git-send-email-felipe.contreras@nokia.com> Date: Fri, 11 Mar 2011 12:05:23 -0600 Message-ID: Subject: Re: [RESEND PATCH] staging: tidspbridge: protect dmm_map properly From: "Ramirez Luna, Omar" To: Felipe Contreras Cc: Felipe Contreras , linux-main , linux-omap , Greg KH , Ohad Ben-Cohen , Fernando Guzman Lugo , Tuomas Kulve Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1685 Lines: 40 Hi Felipe, On Fri, Mar 11, 2011 at 11:38 AM, Felipe Contreras wrote: > On Fri, Mar 11, 2011 at 7:30 PM, Felipe Contreras > wrote: >> We need to protect not only the dmm_map list, but the individual >> map_obj's, otherwise, we might be building the scatter-gather list with >> garbage. So, use the existing proc_lock for that. >> >> I observed race conditions which caused kernel panics while running >> stress tests, also, Tuomas Kulve found it happening quite often in >> Gumstix Over. This patch fixes those. >> >> Cc: Tuomas Kulve >> Signed-off-by: Felipe Contreras > > Omar, 2.6.38 is imminent, if this patch has any chance of getting in, > I think you would need to push it soon. I'll push it to my queue, however I don't think this would be even considered to make it before the official 2.6.38 which should happen in the next few days, given that it should climb to staging tree first and from there to mainline... we could attempt to shot directly to the mainline kernel, but that would raise a few eyebrows and in the end be rejected as well because this is a staging driver which is still in process of cleanup. OTOH, this patch was there long ago, since December, but I just lost the track of it at the moment, along with the other proposed solutions, so I take it as my fault for not picking it up then. Regards, Omar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/