Date: Fri, 11 Mar 2011 13:46:44 -0600
From: scameron@beardog.cce.hp.com
To: Jens Axboe <axboe@kernel.dk>
Cc: mikem@beardog.cce.hp.com, akpm@linux-foundation.org, thenzl@redhat.com,
        linux-kernel@vger.kernel.org, smcameron@yahoo.com,
        scameron@beardog.cce.hp.com
Subject: Re: [PATCH] cciss: Add missing allocation in scsi_cmd_stack_setup and  corresponding deallocation
Message-ID: <20110311194644.GE12760@beardog.cce.hp.com>
References: <20110310202238.30533.92210.stgit@beardog.cce.hp.com> <4D7A7373.8090800@kernel.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D7A7373.8090800@kernel.dk>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1803
Lines: 53

On Fri, Mar 11, 2011 at 08:09:39PM +0100, Jens Axboe wrote:
> On 2011-03-10 21:22, Stephen M. Cameron wrote:
> > From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> > 
> > This bit got lost somewhere along the way.  Without this, panic.
> 
> This doesn't apply cleanly, neither hunk. I hand applied it. Please let
> me know what a patch is against in the future, if it doesn't apply
> "anywhere".

Oh... I see what happened.

That patch was fixing something which was accidentally 
left out of this patch:

http://marc.info/?l=linux-kernel&m=129840572232151&w=2

which I mistakenly thought was present in 2.6.38-rc7,
but it's not present (quite likely because without the
missing bit, it causes a panic), It's sitting in my stack of
patches still.

[scameron@localhost linux-2.6.38-rc7]$ stg series | grep cciss
+ cciss-hoist-tag-masking-out-of-loop
+ cciss-inform-controller-we-are-using-32-bit-tags
+ cciss-mask-off-error-bits-before-calling-pci-free-consistent
+ cciss-remove-unnecessary-casts
+ cciss-fix-missed-command-status-value-CMD_UNABORTABLE
+ cciss-add-cciss_tape_cmds-module-parameter
+ cciss-fix-missing-initialization-in-scsi-cmd-stack-setup
+ cciss-export-resettable-host-attribute
+ cciss-fix-sense-data-copying-code

What needs to happen is I combine cciss-add-cciss_tape_cmds-module-parameter
and cciss-fix-missing-initialization-in-scsi-cmd-stack-setup into one 
working patch.

Sorry about that.  I need to slow down.  I'm making too many mistakes.

-- steve


> 
> I marked this one as stable backport, too.
> 
> -- 
> Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/