Date: Fri, 11 Mar 2011 23:17:29 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Justin TerAvest <teravest@google.com>
Cc: jaxboe@fusionio.com, vgoyal@redhat.com, ctalbott@google.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add unaccounted time to timeslice_used.
Message-ID: <20110312041729.GB15526@home.goodmis.org>
References: <1299877572-30353-1-git-send-email-teravest@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1299877572-30353-1-git-send-email-teravest@google.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1166
Lines: 33

On Fri, Mar 11, 2011 at 01:06:12PM -0800, Justin TerAvest wrote:
> There are two kind of times that tasks are not charged for: the first
> seek and the extra time slice used over the allocated timeslice. Both
> of these exported as a new unaccounted_time stat.
> 
> I think it would be good to have this reported in 'time' as well, but
> that is probably a separate discussion.
> 
> Signed-off-by: Justin TerAvest <teravest@google.com>
> ---
>  block/blk-cgroup.c  |   16 +++++++++++++++-
>  block/blk-cgroup.h  |   12 ++++++++++--
>  block/cfq-iosched.c |   21 +++++++++++++--------
>  block/cfq.h         |    6 +++---
>  4 files changed, 41 insertions(+), 14 deletions(-)

Hi! Just an FYI, could you add what subsystem you are changing into the
subject. Like:

[PATCH] block: Add unaccounted time to timeslice_used

Otherwise, the subject looks like it's modifying the kernel internal time
source.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/