Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754977Ab1CLRl3 (ORCPT ); Sat, 12 Mar 2011 12:41:29 -0500 Received: from kroah.org ([198.145.64.141]:40368 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754506Ab1CLRl0 (ORCPT ); Sat, 12 Mar 2011 12:41:26 -0500 Date: Sat, 12 Mar 2011 09:32:17 -0800 From: Greg KH To: Jonathan Nieder Cc: Indan Zupancic , Arnd Bergmann , Sage Weil , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Aneesh Kumar K. V" , akpm@linux-foundation.org, linux-api@vger.kernel.org, mtk.manpages@gmail.com, viro@zeniv.linux.org.uk, hch@lst.de, l@jasper.es Subject: Re: [PATCH v3] introduce sys_syncfs to sync a single file system Message-ID: <20110312173217.GA24981@kroah.com> References: <201103111255.44979.arnd@arndb.de> <20110311235607.GB15853@elie> <9446ab1a2315c0d2476c30f8315a0503.squirrel@webmail.greenhost.nl> <20110312021001.GA16833@elie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110312021001.GA16833@elie> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 927 Lines: 26 On Fri, Mar 11, 2011 at 08:10:01PM -0600, Jonathan Nieder wrote: > Indan Zupancic wrote: > > > I'm not pushing for any official convention, just what seems good taste. > > In cases like this, conventions (consistency and best practices) are > very important. > > > Less code added, less bloat. Architecture independent, no need to update > > all system call tables everywhere (all archs, libc versions and strace). > > Two files changed, instead of 7 (which only hooks up x86). > > Thanks for explaining. Those do seem like good reasons to use a ioctl > instead of a new syscall. No, make it a syscall, it's more obvious and will be documented much better. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/