Date: Mon, 14 Mar 2011 13:33:55 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: hpa@zytor.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, tlb: small cleanup for native_flush_tlb_others
Message-ID: <20110314123355.GA27477@elte.hu>
References: <4D7DBBE3.1010104@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D7DBBE3.1010104@cn.fujitsu.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1211
Lines: 38


* Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote:

> Use smp_processor_id instead of get_cpu and put_cpu since
> the caller has already disabled preemption
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
>  arch/x86/mm/tlb.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 6acc724..92849d0 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -211,11 +211,10 @@ void native_flush_tlb_others(const struct cpumask *cpumask,
>  	if (is_uv_system()) {
>  		unsigned int cpu;
>  
> -		cpu = get_cpu();
> +		cpu = smp_processor_id();
>  		cpumask = uv_flush_tlb_others(cpumask, mm, va, cpu);
>  		if (cpumask)
>  			flush_tlb_others_ipi(cpumask, mm, va);
> -		put_cpu();
>  		return;

There's multiple callers. Could you please update the changelog with the list of 
callers and a statement that all of them disable preemption already?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/