Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755759Ab1CNMrW (ORCPT ); Mon, 14 Mar 2011 08:47:22 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:52931 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755717Ab1CNMrU (ORCPT ); Mon, 14 Mar 2011 08:47:20 -0400 Date: Mon, 14 Mar 2011 12:46:52 +0000 From: Russell King - ARM Linux To: KyongHo Cho Cc: Arnd Bergmann , Tomasz Stanislawski , k.debski@samsung.com, linux-samsung-soc@vger.kernel.org, =?utf-8?B?6rCV66+86rec?= , linux-kernel@vger.kernel.org, =?utf-8?B?64yA7J246riw?= , kyungmin.park@samsung.com, kgene.kim@samsung.com, Sylwester Nawrocki , Andrzej Pietrasiewicz , Marek Szyprowski , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH 3/7] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver Message-ID: <20110314124652.GF26085@n2100.arm.linux.org.uk> References: <1299229274-9753-4-git-send-email-m.szyprowski@samsung.com> <201103111615.01829.arnd@arndb.de> <000201cbe002$768d9de0$63a8d9a0$%szyprowski@samsung.com> <201103111700.17373.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2016 Lines: 38 On Mon, Mar 14, 2011 at 09:37:51PM +0900, KyongHo Cho wrote: > I have also noticed that dma_map_single/page/sg() can map physical > memory into an arbitrary device address region. > But it is not enough solution for various kinds of IOMMUs. > As Kukjin Kim addressed, we need to support larger page size than 4KB > because we can reduce TLB miss when we have larger page size. > > Our IOMMU(system mmu) supports all page size of ARM architecture > including 16MB, 1MB, 64KB and 4KB. > Since the largest size supported by buddy system of 32-bit architecture is 4MB, > our system support all page sizes except 16MB. > We proved that larger page size is helpful for DMA performance > significantly (more than 10%, approximately). > Big page size is not a problem for peripheral devices > because their address space is not suffer from external fragmentation. 1. dma_map_single() et.al. is used for mapping *system* *RAM* for devices using whatever is necessary. It must not be used for trying to setup arbitary other mappings. 2. It doesn't matter where the memory for dma_map_single() et.al. comes from provided the virtual address is a valid system RAM address or the struct page * is a valid struct page in the memory map (iow, you can't create this yourself.) 3. In the case of an IOMMU, the DMA API does not limit you to only using 4K pages to setup the IOMMU mappings. You can use whatever you like provided the hardware can cope with it. You can coalesce several existing entries together provided you track what you're doing and can undo what's been done when the mapping is no longer required. So really there's no reason not to use 64K, 1M and 16M IOMMU entries if that's the size of buffer which has been passed to the DMA API. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/