Date: Mon, 14 Mar 2011 15:04:05 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jesper Juhl <jj@chaosbits.net>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        greg@kroah.com, joe@perches.com, akpm@linux-foundation.org
Subject: Re: [PATCH][rfc] Use int as return type of main in
 arch/x86/boot/main.c
Message-ID: <20110314190404.GB20259@home.goodmis.org>
References: <alpine.LNX.2.00.1103132257430.9985@swampdragon.chaosbits.net>
 <20110314113254.GA2761@gmail.com>
 <4D7E470E.8090204@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D7E470E.8090204@zytor.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 709
Lines: 20

On Mon, Mar 14, 2011 at 09:49:18AM -0700, H. Peter Anvin wrote:
> On 03/14/2011 04:32 AM, Harry Wei wrote:
> > On Sun, Mar 13, 2011 at 11:00:09PM +0100, Jesper Juhl wrote:
> >> I believe the return type of main should always be 'int'.
> >>
> >> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > Acked-by: Harry Wei <harryxiyou@gmail.com>
> 
> It would make more sense to rename the function to something other than
> main().

Right, maybe "boot_start"?

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/