Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756218Ab1CNTOP (ORCPT ); Mon, 14 Mar 2011 15:14:15 -0400 Received: from kroah.org ([198.145.64.141]:45733 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755954Ab1CNTOM (ORCPT ); Mon, 14 Mar 2011 15:14:12 -0400 Date: Mon, 14 Mar 2011 12:00:00 -0700 From: Greg KH To: Ilia Mirkin Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/24] staging: hv: Remove NULL check before kfree Message-ID: <20110314190000.GA28040@kroah.com> References: <20110222145452.GD1331@suse.de> <1299994157-11191-1-git-send-email-imirkin@alum.mit.edu> <1299994157-11191-2-git-send-email-imirkin@alum.mit.edu> <1299994157-11191-3-git-send-email-imirkin@alum.mit.edu> <1299994157-11191-4-git-send-email-imirkin@alum.mit.edu> <1299994157-11191-5-git-send-email-imirkin@alum.mit.edu> <1299994157-11191-6-git-send-email-imirkin@alum.mit.edu> <1299994157-11191-7-git-send-email-imirkin@alum.mit.edu> <1299994157-11191-8-git-send-email-imirkin@alum.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1299994157-11191-8-git-send-email-imirkin@alum.mit.edu> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 31 On Sun, Mar 13, 2011 at 12:29:00AM -0500, Ilia Mirkin wrote: > This patch was generated by the following semantic patch: > // > @@ expression E; @@ > - if (E != NULL) { kfree(E); } > + kfree(E); > > @@ expression E; @@ > - if (E != NULL) { kfree(E); E = NULL; } > + kfree(E); > + E = NULL; > // > > Signed-off-by: Ilia Mirkin > --- > drivers/staging/hv/channel_mgmt.c | 3 +-- > drivers/staging/hv/connection.c | 4 +--- > drivers/staging/hv/hv_mouse.c | 12 ++++-------- > 3 files changed, 6 insertions(+), 13 deletions(-) Let me sync up with the other hyperv patches in my queue before applying this one, don't worry, it's not lost... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/