Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756302Ab1CNUDz (ORCPT ); Mon, 14 Mar 2011 16:03:55 -0400 Received: from smtp-out.google.com ([74.125.121.67]:42541 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244Ab1CNUDy convert rfc822-to-8bit (ORCPT ); Mon, 14 Mar 2011 16:03:54 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=Jvvp6OBwGn9YqLGvlPKqklsh/4c6EJ/MkR35thAk9LVDwroqtR8Yr7vH92+HL+9xjf y0DyWirXCi1RqOop08VA== MIME-Version: 1.0 In-Reply-To: <4D7D9F92.5010604@kernel.org> References: <20110312014254.6133.43079.stgit@mike.mtv.corp.google.com> <20110312014358.6133.34911.stgit@mike.mtv.corp.google.com> <4D7D9F92.5010604@kernel.org> From: Mike Waychison Date: Mon, 14 Mar 2011 13:03:30 -0700 Message-ID: Subject: Re: [PATCH v2 12/12] driver: Google Memory Console To: "H. Peter Anvin" Cc: Greg KH , Matt Domsch , Alan Cox , Duncan Laurie , Aaron Durbin , x86@kernel.org, linux-kernel@vger.kernel.org, Tim Hockin , San Mehat Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 27 On Sun, Mar 13, 2011 at 9:54 PM, H. Peter Anvin wrote: > On 03/11/2011 05:43 PM, Mike Waychison wrote: >> This patch introduces the 'memconsole' driver. >> >> Our firmware gives us access to an in-memory log of the firmware's >> output. ? This gives us visibility in a data-center of headless machines >> as to what the firmware is doing. >> >> The memory console is found by the driver by finding a header block in >> the EBDA. ?The buffer is then copied out, and is exported to userland in >> the file /sys/firmware/log. >> > > OK, I really don't like this. > > All it has is a 32-bit nonrandom signature, no DMI keying or anything > else to protect it. ?This really isn't sufficient. Good point. I'll add some DMI strings checks. It *should* be sufficient to just ensure that "Google, Inc." is the board vendor string (though I'll need to run some tests to verify that this covers the boards we care about). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/