Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504Ab1CNXfX (ORCPT ); Mon, 14 Mar 2011 19:35:23 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:19297 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053Ab1CNXfW (ORCPT ); Mon, 14 Mar 2011 19:35:22 -0400 Date: Tue, 15 Mar 2011 00:35:02 +0100 (CET) From: Jesper Juhl To: "H. Peter Anvin" cc: linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , greg@kroah.com, joe@perches.com, akpm@linux-foundation.org Subject: Re: [PATCH][rfc] Use int as return type of main in arch/x86/boot/main.c In-Reply-To: <4D7E470E.8090204@zytor.com> Message-ID: References: <20110314113254.GA2761@gmail.com> <4D7E470E.8090204@zytor.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 24 On Mon, 14 Mar 2011, H. Peter Anvin wrote: > On 03/14/2011 04:32 AM, Harry Wei wrote: > > On Sun, Mar 13, 2011 at 11:00:09PM +0100, Jesper Juhl wrote: > >> I believe the return type of main should always be 'int'. > >> > >> Signed-off-by: Jesper Juhl > > Acked-by: Harry Wei > > It would make more sense to rename the function to something other than > main(). > Right. That's probably a better aproach. Thanks. -- Jesper Juhl http://www.chaosbits.net/ Plain text mails only, please. Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/