Subject: Re: [01/22] sched: Provide scheduler_ipi() callback in response to
 smp_send_reschedule()
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
From: Milton Miller <miltonm@bga.com>
Cc: Chris Mason <chris.mason@oracle.com>,
        Frank Rowand <frank.rowand@am.sony.com>, Ingo Molnar <mingo@elte.hu>,
        Thomas Gleixner <tglx@linutronix.de>, Mike Galbraith <efault@gmx.de>,
        Oleg Nesterov <oleg@redhat.com>, Paul Turner <pjt@google.com>,
        Jens Axboe <axboe@kernel.dk>, Yong Zhang <yong.zhang0@gmail.com>,
        linux-kernel@vger.kernel.org,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Chris Metcalf <cmetcalf@tilera.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Ralf Baechle <ralf@linux-mips.org>
In-Reply-To: <1299857247.2308.5990.camel@twins>
References: <20110302174120.313761743@chello.nl>
	 <sched-ipi-callback-comment@mdm.bga.com>
	<1299857247.2308.5990.camel@twins>
Message-ID: <sched-ipi-callback-comment-2@mdm.bga.com>
Date: Mon, 14 Mar 2011 21:59:18 -0600
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1347
Lines: 31

On Fri, 11 Mar 2011 16:27:27 +0100, Peter Zijlstra wrote:
> 
> On Fri, 2011-03-11 at 09:07 -0600, Milton Miller wrote:
> > >       case PPC_MSG_RESCHEDULE:
> > >               /* we notice need_resched on exit */
> > > +		    smp_reschedule_ipi()
> >
> > This comment should also be removed, as it was documenting the empty
> > action.
> 
> But its still true, TIF_NEED_RESCHED isn't going away and we still
> notice that on the interrupt return path.

Just because it is true does not mean it is useful.  Why is this site
different than the twenty odd other call sites that it needs to document
the behaivors requried upon exiting the kernel from interrupt deep in this
interrupt handling call path?  Why is it not placed after the call, where
it would talk about what happens next instead of what will happen later?
For that matter, what does on exit mean?

I went ahead and sent this when I saw the comments questioning the
sparc 32 part of the patch and thought you might respin.  But if this is
already committed then I will submit a followup patch for consideration
after this is merged.

milton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/