Date: Tue, 15 Mar 2011 08:13:34 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Mike Waychison <mikew@google.com>
Cc: Greg KH <greg@kroah.com>, Matt Domsch <Matt_Domsch@dell.com>,
        Alan Cox <alan@lxorguk.ukuu.org.uk>,
        Duncan Laurie <dlaurie@google.com>, Aaron Durbin <adurbin@google.com>,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        Tim Hockin <thockin@google.com>, San Mehat <san@google.com>
Subject: Re: [PATCH v3 5/5] driver: Google Memory Console
Message-ID: <20110315071334.GA29969@elte.hu>
References: <20110315065839.12047.70666.stgit@mike.mtv.corp.google.com>
 <20110315065905.12047.71103.stgit@mike.mtv.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110315065905.12047.71103.stgit@mike.mtv.corp.google.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 837
Lines: 36


* Mike Waychison <mikew@google.com> wrote:

> +static struct dmi_system_id memconsole_dmi_table[] __initdata = {
> +	{
> +		.ident = "Google Board",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Google, Inc."),
> +		},
> +	},
> +	{}
> +};
> +MODULE_DEVICE_TABLE(dmi, memconsole_dmi_table);
> +
> +static int __init memconsole_init(void)
> +{
> +	int ret;
> +
> +	if (!dmi_check_system(memconsole_dmi_table))
> +		return -ENODEV;
> +
> +	if (!found_memconsole())
> +		return -ENODEV;

Ok, that's a much safer method of discovery.

Acked-by: Ingo Molnar <mingo@elte.hu>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/