Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757011Ab1COKYH (ORCPT ); Tue, 15 Mar 2011 06:24:07 -0400 Received: from verein.lst.de ([213.95.11.211]:39934 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754699Ab1COKYF (ORCPT ); Tue, 15 Mar 2011 06:24:05 -0400 Date: Tue, 15 Mar 2011 11:24:04 +0100 From: Christoph Hellwig To: "Nicholas A. Bellinger" Cc: linux-scsi , linux-kernel , James Bottomley , Christoph Hellwig , Mike Christie , Hannes Reinecke , FUJITA Tomonori , Boaz Harrosh , Stephen Rothwell , Douglas Gilbert Subject: Re: [RFC-v2 07/12] iscsi-target: Add CHAP Authentication support using libcrypto Message-ID: <20110315102404.GB24496@lst.de> References: <1300103829-10337-1-git-send-email-nab@linux-iscsi.org> <1300103829-10337-8-git-send-email-nab@linux-iscsi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1300103829-10337-8-git-send-email-nab@linux-iscsi.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 25 On Mon, Mar 14, 2011 at 04:57:04AM -0700, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds support for libcrypto md5 based iSCSI CHAP authentication > support for iscsi_target_mod. This includes support for mutual and one-way > NodeACL authentication for SessionType=Normal and SessionType=Discovery > via /sys/kernel/config/target/iscsi. > > Signed-off-by: Nicholas A. Bellinger > --- > drivers/target/iscsi/iscsi_auth_chap.c | 502 ++++++++++++++++++++++++++++++++ > drivers/target/iscsi/iscsi_auth_chap.h | 33 ++ > 2 files changed, 535 insertions(+), 0 deletions(-) > create mode 100644 drivers/target/iscsi/iscsi_auth_chap.c > create mode 100644 drivers/target/iscsi/iscsi_auth_chap.h Why aren't these files named iscsi_target_* like most others? If you prefix all files in a module please do it consistently, or alternatively just drop the prefix altogether. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/