Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758185Ab1COQTc (ORCPT ); Tue, 15 Mar 2011 12:19:32 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34816 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757233Ab1COQTb (ORCPT ); Tue, 15 Mar 2011 12:19:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <4D7F2C11.907@orcon.net.nz> From: Linus Torvalds Date: Tue, 15 Mar 2011 09:17:59 -0700 Message-ID: Subject: Re: Alpha no longer recognises certain partition tables (v2.6.38) To: Michael Cree Cc: linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, warns@pre-sense.de Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 24 On Tue, Mar 15, 2011 at 8:10 AM, Linus Torvalds wrote: > > Also, it's quite possible that we should raise the value of > MAX_OSF_PARTITIONS. If I checked it right, the d_partitions[] array > starts at byte offset 148 in the sector, and it's 16 bytes in size, so > there _could_ be up to 22 partitions there. Actually, I think it's byte offset 148 in the structure, but the structure is at offset 64 in the partition sector, so I think that leaves room for just 18 partitions in one 512-byte sector. Of course, we do end up reading a whole page, so historically we've been able to see even more when the sector is aligned right (and it is, it's the first sector). So by mistake we could have accepted many more partitions and it just "worked" because we never actually checked any limits. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/