Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758402Ab1COT1V (ORCPT ); Tue, 15 Mar 2011 15:27:21 -0400 Received: from mail4.comsite.net ([205.238.176.238]:56382 "EHLO mail4.comsite.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153Ab1COT1Q (ORCPT ); Tue, 15 Mar 2011 15:27:16 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=71.22.127.106; Subject: [PATCH 0/4 v3] smp_call_function_many issues from review From: Milton Miller To: Peter Zijlstra , akpm@linux-foundation.org Cc: Anton Blanchard , xiaoguangrong@cn.fujitsu.com, mingo@elte.hu, jaxboe@fusionio.com, npiggin@gmail.com, rusty@rustcorp.com.au, efault@gmx.de, Jan Beulich , Dimitri Sivanich , Tony Luck , torvalds@linux-foundation.org, paulmck@linux.vnet.ibm.com, benh@kernel.crashing.org, linux-kernel@vger.kernel.org References: <20110112150740.77dde58c@kryten> <1295288253.30950.280.camel@laptop> <1296145360.15234.234.camel@laptop> <20110201220026.GD2142@linux.vnet.ibm.com> <20110202041740.GB2129@linux.vnet.ibm.com> <20110206235136.GA23658@linux.vnet.ibm.com> In-Reply-To: <20110206235136.GA23658@linux.vnet.ibm.com> Message-ID: Date: Tue, 15 Mar 2011 13:27:15 -0600 X-Originating-IP: 71.22.127.106 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 37 Picking up this thread from the beginning of Feburary, I updated the comments in 3 and 4 based on Paul's review. I have inserted my proposed alternative to Paul's additional patch as patch 2, and tweaked the changelog on 1. [PATCH 1/4 v3] call_function_many: fix list delete vs add race [PATCH 2/4 v3] call_function_many: add missing ordering [PATCH 3/4 v3] smp_call_function_many: handle concurrent clearing of mask [PATCH 4/4 v3] smp_call_function_interrupt: use typedef and %pf Peter Z acked a prior version of patch 1, and Mike Galbraith has done some stress testing on the combinaton of 1,3,4, and Paul's patch. The prior posting of this series is available here: https://patchwork.kernel.org/patch/522021/ https://patchwork.kernel.org/patch/522031/ http://marc.info/?l=linux-kernel&m=129654439817236&w=2 And Paul's additional patch from review was here https://patchwork.kernel.org/patch/525891/ Looking forward, I would suggest 1 and 2 are required for stable, 3 may be suitable as it fixes races that otherwise requires cpumask copies as in 75c1c91cb92806f960fcd6e53d2a0c21f343081c ([IA64] eliminate race condition in smp_flush_tlb_mm). By contrast 4 is just comments except for the %pS to %pf change. Dimitri or Tony, let me know if you would like a revert patch for 75c1c91c to be added after patch 3. milton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/