Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758066Ab1COUL2 (ORCPT ); Tue, 15 Mar 2011 16:11:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20612 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755392Ab1COUL1 (ORCPT ); Tue, 15 Mar 2011 16:11:27 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1300211077.3748.2.camel@localhost.localdomain> References: <1300211077.3748.2.camel@localhost.localdomain> <20110310202516.GA16122@suse.de> <20110307210656.GA1750@suse.de> <18893.1299607373@redhat.com> <29980.1299861232@redhat.com> <20110315173810.GA12775@suse.de> To: Eric Paris Cc: dhowells@redhat.com, Tony Jones , linux-kernel@vger.kernel.org, linux-audit@redhat.com, Al Viro Subject: Re: PATCH [1/1]: audit: acquire creds selectively to reduce atomic op overhead Date: Tue, 15 Mar 2011 20:11:17 +0000 Message-ID: <21526.1300219877@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 495 Lines: 13 Eric Paris wrote: > WARN_ON(cred != current->cred && cred->refcnt != 1) 'tsk->parent == current' perhaps? Or audit_alloc() could pass a flag indicating the state, or just look to see if tsk->audit_context is still NULL. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/