Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758570Ab1COUUY (ORCPT ); Tue, 15 Mar 2011 16:20:24 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:43020 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758139Ab1COUUW (ORCPT ); Tue, 15 Mar 2011 16:20:22 -0400 Date: Tue, 15 Mar 2011 13:18:46 -0700 From: Andrew Morton To: Andreas Dilger Cc: Dave Chinner , Sage Weil , Indan Zupancic , Greg KH , Jonathan Nieder , Arnd Bergmann , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Aneesh Kumar K. V" , "linux-api@vger.kernel.org" , "mtk.manpages@gmail.com" , "viro@zeniv.linux.org.uk" , "hch@lst.de" , "l@jasper.es" Subject: Re: [PATCH v3] introduce sys_syncfs to sync a single file system Message-Id: <20110315131846.4d41af3c.akpm@linux-foundation.org> In-Reply-To: References: <201103111255.44979.arnd@arndb.de> <20110311235607.GB15853@elie> <9446ab1a2315c0d2476c30f8315a0503.squirrel@webmail.greenhost.nl> <20110312021001.GA16833@elie> <20110312173217.GA24981@kroah.com> <1e597aedd3d7825dcc0630b1cf2399fa.squirrel@webmail.greenhost.nl> <20110315101155.GO15097@dastard> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 22 On Tue, 15 Mar 2011 09:56:08 -0600 Andreas Dilger wrote: > Should there be a "wait" argument or flag that allows an app to start the syncfs(), do something, and then call again to wait for completion? I don't think so. If userspace wants to do that then fork(). > > Perhaps we should consider propagating errors out to the user > > application rather than discarding them in kernel and pretending we > > can't ever have a write error? That would be nice, but is probably a pretty complex thing to implement. The manpage should include words indicating that syncfs() can return an errno. That way, userspace will hopefully have the appropriate checks, whcih will become more useful if/when the kernel implementation gets fixed up. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/