Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758555Ab1COUcd (ORCPT ); Tue, 15 Mar 2011 16:32:33 -0400 Received: from mout.perfora.net ([74.208.4.194]:51287 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758192Ab1COUcc (ORCPT ); Tue, 15 Mar 2011 16:32:32 -0400 Date: Tue, 15 Mar 2011 16:31:17 -0400 From: Stephen Wilson To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Ananth N Mavinakayanahalli , Christoph Hellwig , Andi Kleen , Masami Hiramatsu , Oleg Nesterov , LKML , Jim Keniston , Roland McGrath , SystemTap , Andrew Morton , "Paul E. McKenney" Subject: Re: [PATCH v2 2.6.38-rc8-tip 11/20] 11: uprobes: slot allocation for uprobes Message-ID: <20110315203117.GA27063@fibrous.localdomain> References: <20110314133403.27435.7901.sendpatchset@localhost6.localdomain6> <20110314133610.27435.93666.sendpatchset@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110314133610.27435.93666.sendpatchset@localhost6.localdomain6> User-Agent: Mutt/1.5.19 (2009-01-05) X-Provags-ID: V02:K0:6on3DlLg7FpaqYwU9fY3i8OTv3bpG6YOoio6/rhLtcI UR89fpmTburUTk1uZrQ34DxV15M3/tXZPIntzwtNWxmxVnwB0x r0m858clFi4x6kijicAOiEYJyoaV2KHoueaVyNG4A0nR0LXSus 1mhS2nnj5PdOmC2PF9skm/e/lrzHb+dDw3CK74U+oj/YfAMsUB CI7HlBN6Pq3It+Ql0NeBv50KwiKgz6j97yWNFsUxfk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 36 On Mon, Mar 14, 2011 at 07:06:10PM +0530, Srikar Dronamraju wrote: > diff --git a/kernel/fork.c b/kernel/fork.c > index de3d10a..0afa0cd 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -551,6 +551,7 @@ void mmput(struct mm_struct *mm) > might_sleep(); > > if (atomic_dec_and_test(&mm->mm_users)) { > + uprobes_free_xol_area(mm); > exit_aio(mm); > ksm_exit(mm); > khugepaged_exit(mm); /* must run before exit_mmap */ > @@ -677,6 +678,9 @@ struct mm_struct *dup_mm(struct task_struct *tsk) > memcpy(mm, oldmm, sizeof(*mm)); > > /* Initializing for Swap token stuff */ > +#ifdef CONFIG_UPROBES > + mm->uprobes_xol_area = NULL; > +#endif > mm->token_priority = 0; > mm->last_interval = 0; Perhaps move the uprobes_xol_area initialization away from that comment? A few lines down beside the hugepage #ifdef would read a bit better. -- steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/