DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=3FLz5kEqlFTIVphgkZPPjL64hnJIodkrGPYyB9fLuAWsIMbiANIB/A6TbP43rqdPoixRvdGlQbnLsTKpdj80tT00UGwItuoldkxfjwb6MTooWn//2PAch4+ZsW8QhA+bWVHqgtD6Q/o9EUMQMPEexYiCFlRA+T2aFzhVB93lRKc=;
Message-ID: <403815.22502.qm@web37607.mail.mud.yahoo.com>
Date: Tue, 15 Mar 2011 21:18:14 -0700 (PDT)
From: Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH 1/4] scatterlist: new helper functions
To: akpm@linux-foundation.org, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: maximlevitsky@gmail.com, fujita.tomonori@lab.ntt.co.jp,
        James.Bottomley@HansenPartnership.com, linux-kernel@vger.kernel.org
In-Reply-To: <20110316113527C.fujita.tomonori@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1255
Lines: 40


> 
> I don't think so.
> 
> Splitting (or merging) a request and playing with sg lists
> inside a
> driver is a bad idea. Such should be done in the block
> layer.
> 
> I still don't see why the block layer can't do that for the
> driver.
> 
> I believe that the helper functions for such should not be
> added.
> 


In a particular case of flash-like devices, letting the block layer
split requests into memory sequential blocks too often results in
unnecessary fragmentation of writes/erases.

If only one sg entry is requested from the block layer, it will be (more
often than not) only 1 or 2 pages in length, even if total size of
prospective write request spans multiple erase blocks.

So there are really only two options for legacy memorystick driver:
1. Play with scatterlists explicitly.
2. Make it an MTD backend, rather then stand-alone block device.

The second option makes more sense, but it is not necessarily the optimal
approach for implementation of this particular media format.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/