Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751607Ab1CPGpO (ORCPT ); Wed, 16 Mar 2011 02:45:14 -0400 Received: from asset.uwaterloo.ca ([129.97.92.29]:55711 "EHLO asset.uwaterloo.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315Ab1CPGpL (ORCPT ); Wed, 16 Mar 2011 02:45:11 -0400 Date: Wed, 16 Mar 2011 02:45:09 -0400 From: j223yang@asset.uwaterloo.ca To: linux-nfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [patch]xprt: remove redundant checks Message-ID: <20110316064509.GA1498@asset.uwaterloo.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 40 'req' is already dereferenced in 'struct rpc_xprt *xprt = req->rq_xprt;', but check again later in the function. The patch removes these redundant checks. Signed-off-by: Jinqiu Yang --- xprt.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/sunrpt/xprt.c b/net/sunrpt/xprt.c --- a/net/sunrpc/xprt.c 2011-03-16 00:10:08.764164573 -0400 +++ b/net/sunrpt/xprt.c 2011-03-16 02:33:38.559164414 -0400 @@ -202,10 +202,8 @@ int xprt_reserve_xprt(struct rpc_task *t goto out_sleep; } xprt->snd_task = task; - if (req) { - req->rq_bytes_sent = 0; - req->rq_ntrans++; - } + req->rq_bytes_sent = 0; + req->rq_ntrans++; return 1; out_sleep: @@ -213,7 +211,7 @@ out_sleep: task->tk_pid, xprt); task->tk_timeout = 0; task->tk_status = -EAGAIN; - if (req && req->rq_ntrans) + if (req->rq_ntrans) rpc_sleep_on(&xprt->resend, task, NULL); else rpc_sleep_on(&xprt->sending, task, NULL); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/