Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752402Ab1CPJNv (ORCPT ); Wed, 16 Mar 2011 05:13:51 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:42354 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870Ab1CPJNp convert rfc822-to-8bit (ORCPT ); Wed, 16 Mar 2011 05:13:45 -0400 MIME-Version: 1.0 X-Originating-IP: [81.245.213.92] In-Reply-To: References: <1299608733-28514-1-git-send-email-sheetals@codeaurora.org> <1299691007-13470-1-git-send-email-sheetals@codeaurora.org> <4D7EC274.4020407@codeaurora.org> Date: Wed, 16 Mar 2011 10:13:44 +0100 Message-ID: Subject: Re: [PATCH v4 2/3] [ARM] perfevents: Add support for Scorpion performance monitors From: Jean Pihet To: Sheetal Sahasrabudhe , Russell King - ARM Linux , Nicolas Pitre Cc: will.deacon@arm.com, Bryan Huntsman , linux-arm-kernel@lists.infradead.org, jamie.iles@picochip.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2469 Lines: 71 On Tue, Mar 15, 2011 at 4:58 PM, Sheetal Sahasrabudhe wrote: > Hi Will/Jean, > > On Mon, March 14, 2011 6:35 pm, Bryan Huntsman wrote: >> On 03/09/2011 09:16 AM, Sheetal Sahasrabudhe wrote: >>> This commit adds support for performance monitors provided by >>> Qualcomm Scorpion and ScorpionMP processor to perfevents. >>> >>> Signed-off-by: Sheetal Sahasrabudhe >>> Reviewed-by: Jean Pihet >>> Reviewed-by: Will Deacon >>> --- >>> ?arch/arm/include/asm/perf_event.h | ? ?2 + >>> ?arch/arm/kernel/perf_event.c ? ? ?| ? 11 + >>> ?arch/arm/kernel/perf_event_msm.c ?| ?679 +++++++++++++++++++++++++++++++++++++ >>> ?3 files changed, 692 insertions(+), 0 deletions(-) >>> ?create mode 100644 arch/arm/kernel/perf_event_msm.c >>> >> >> ... >> >>> diff --git a/arch/arm/kernel/perf_event_msm.c b/arch/arm/kernel/perf_event_msm.c >>> new file mode 100644 >>> index 0000000..4e42f27 >>> --- /dev/null >>> +++ b/arch/arm/kernel/perf_event_msm.c > [...] > >>> +#include >>> +#include >>> +#include "../vfp/vfpinstr.h" >> >> Sorry I didn't see this earlier. ?Is there another way to get the info >> you need that wouldn't use a relative include path? ?If the info from >> vfpinstr.h is now needed outside of the vfp directory, can it be moved >> to a common header instead? ?Thanks. Good catch! Sorry I did not catch this one while reviewing the code. >> >> - Bryan > > I see other files under vfp that include this header. > So if we were to implement Bryan's suggestion, I think a separate patch that moves the header and updates all the depdendencies would be more appropriate. > Are you okay with the relative include path for vfpinstr.h in this patch for now or would you want to see an update to move vfpinstr.h to include/asm?. Adding Russell and Nicolas for the VFP question. Only fmrx and fmxr are used from "../vfp/vfpinstr.h". Can those be moved to arch/arm/include/asm/vfp.h? What is the best solution to this? Regards, Jean > > Thanks, > Sheetal > > -- > Sent by an employee of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/