Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494Ab1CPSR2 (ORCPT ); Wed, 16 Mar 2011 14:17:28 -0400 Received: from fxip-0047f.externet.hu ([88.209.222.127]:39048 "EHLO pomaz-ex.szeredi.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517Ab1CPSRW (ORCPT ); Wed, 16 Mar 2011 14:17:22 -0400 To: Linus Torvalds CC: miklos@szeredi.hu, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org In-reply-to: (message from Linus Torvalds on Wed, 16 Mar 2011 10:42:59 -0700) Subject: Re: [git pull] several fixes References: <20110316144253.GT22723@ZenIV.linux.org.uk> Message-Id: From: Miklos Szeredi Date: Wed, 16 Mar 2011 19:17:19 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 19 On Wed, 16 Mar 2011, Linus Torvalds wrote: > On Wed, Mar 16, 2011 at 10:17 AM, Miklos Szeredi wrote: > > > > __fput doesn't need a cdev_put() for O_PATH handles. > > "doesn't need" or "must not have"? It must not have one, otherwise refcounting will go astray. That cdev_put() should really be moved into f_op->release(), but that would be quite a bit of work. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/