Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175Ab1CQMPa (ORCPT ); Thu, 17 Mar 2011 08:15:30 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:44895 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752910Ab1CQMP2 convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2011 08:15:28 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=OcqFZoGe+cSvjYKZXq4mGVMnArBXE5bNzxLx7Iffk+FAsa7mehWOd/VqQKLotMlZzC 7MsBZcFxaKen45llpXWwH2iNGbQqBjXDfhYyisSH68i7ukL7qP3d2v8Ea8MtkjlrjUgO WDiU0l/gDk+O7ierC7XtWK1Ok+LSCV9YIi78U= MIME-Version: 1.0 In-Reply-To: <20110317113229.GA7710@albatros> References: <1299780740-32652-1-git-send-email-segoon@openwall.com> <4D7F5CAC.6070006@trash.net> <20110317113229.GA7710@albatros> From: Changli Gao Date: Thu, 17 Mar 2011 20:15:06 +0800 Message-ID: Subject: Re: [PATCH v2] ipv4: netfilter: ipt_CLUSTERIP: fix buffer overflow To: Vasiliy Kulikov Cc: Patrick McHardy , linux-kernel@vger.kernel.org, security@kernel.org, "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 21 On Thu, Mar 17, 2011 at 7:32 PM, Vasiliy Kulikov wrote: > 'buffer' string is copied from userspace. ?It is not checked whether it is > zero terminated. ?This may lead to overflow inside of simple_strtoul(). > Changli Gao suggested to copy not more than user supplied 'size' bytes. > > It was introduced before the git epoch. ?Files "ipt_CLUSTERIP/*" are > root writable only by default, however, on some setups permissions might be > relaxed to e.g. network admin user. > > Signed-off-by: Vasiliy Kulikov Acked-by: Changli Gao -- Regards, Changli Gao(xiaosuo@gmail.com) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/