Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755185Ab1CQTzo (ORCPT ); Thu, 17 Mar 2011 15:55:44 -0400 Received: from cpoproxy3-pub.bluehost.com ([67.222.54.6]:55780 "HELO cpoproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754481Ab1CQTzl (ORCPT ); Thu, 17 Mar 2011 15:55:41 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=xenotime.net; h=Received:Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:Organization:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=DNumbm5HO1DI808GxtLMwJjJL0X1RZD7yYEEPHzwiqEnm2xzKy+dOE9QqB4q0+AEu6fUbE7QzcLeQ/pUCQB0eoWmktKmiN9rj5cZXJqRqKThF6zCar2PBf4pN+clANUk; Date: Thu, 17 Mar 2011 12:55:38 -0700 From: Randy Dunlap To: Greg KH Cc: Linus Torvalds , devel@linuxdriverproject.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [GIT PATCH] STAGING patches for .39 Message-Id: <20110317125538.791c26d9.rdunlap@xenotime.net> In-Reply-To: <20110317020212.GA2115@kroah.com> References: <20110316210300.GA3311@kroah.com> <20110317002818.GA19812@kroah.com> <20110317015239.GB31754@kroah.com> <20110317020212.GA2115@kroah.com> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 173.50.240.230 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2735 Lines: 77 On Wed, 16 Mar 2011 19:02:12 -0700 Greg KH wrote: > On Wed, Mar 16, 2011 at 06:52:39PM -0700, Greg KH wrote: > > On Wed, Mar 16, 2011 at 05:34:08PM -0700, Linus Torvalds wrote: > > > On Wed, Mar 16, 2011 at 5:32 PM, Linus Torvalds > > > wrote: > > > > > > > > The one with inifinite errors was vt6655. > > > > > > vt6656 had same/similar issues. In fact, maybe it's simply because I > > > built both of them in, and get infinite "multiple definitions" because > > > they are the same driver with small differences? > > > > Ah, probably, if they are both built into the kernel that might happen > > due to the global symbols in them. Actually that's odd, Randy's usual > > 'randconfig' tester usually catches these, I'll make the Kconfig files > > force them to be modules to keep this from happening in the future. > > Yes, that looks like the problem, as building them as modules in your > tree right now works just fine. > > This patch below should solve your build issue, let me know if it > doesn't. Thanks for the patch. You had suggested 1-2 months ago that someone do this, so I was waiting to see if someone would actually do it. I was hoping that a staging developer would do it (not the staging maintainer). > thanks, > > greg k-h > > ----------------- > From: Greg Kroah-Hartman > Subject: staging: force vt6655 and vt6656 drivers to be built as modules > > If they both get built into the kernel, the global symbols in them > conflict and lots of link errors happen. > > Signed-off-by: Greg Kroah-Hartman > > > diff --git a/drivers/staging/vt6655/Kconfig b/drivers/staging/vt6655/Kconfig > index 061e730..c3ba693 100644 > --- a/drivers/staging/vt6655/Kconfig > +++ b/drivers/staging/vt6655/Kconfig > @@ -1,6 +1,6 @@ > config VT6655 > tristate "VIA Technologies VT6655 support" > - depends on PCI && WLAN > + depends on PCI && WLAN && m > select WIRELESS_EXT > select WEXT_PRIV > ---help--- > diff --git a/drivers/staging/vt6656/Kconfig b/drivers/staging/vt6656/Kconfig > index a441ba5..f89ab20 100644 > --- a/drivers/staging/vt6656/Kconfig > +++ b/drivers/staging/vt6656/Kconfig > @@ -1,6 +1,6 @@ > config VT6656 > tristate "VIA Technologies VT6656 support" > - depends on USB && WLAN > + depends on USB && WLAN && m > select WIRELESS_EXT > select WEXT_PRIV > select FW_LOADER --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/