Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755396Ab1CQUN0 (ORCPT ); Thu, 17 Mar 2011 16:13:26 -0400 Received: from kroah.org ([198.145.64.141]:52604 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755190Ab1CQUNY (ORCPT ); Thu, 17 Mar 2011 16:13:24 -0400 Date: Thu, 17 Mar 2011 13:04:48 -0700 From: Greg KH To: Randy Dunlap Cc: Linus Torvalds , devel@linuxdriverproject.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [GIT PATCH] STAGING patches for .39 Message-ID: <20110317200448.GA17827@kroah.com> References: <20110316210300.GA3311@kroah.com> <20110317002818.GA19812@kroah.com> <20110317015239.GB31754@kroah.com> <20110317020212.GA2115@kroah.com> <20110317125538.791c26d9.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110317125538.791c26d9.rdunlap@xenotime.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1873 Lines: 45 On Thu, Mar 17, 2011 at 12:55:38PM -0700, Randy Dunlap wrote: > On Wed, 16 Mar 2011 19:02:12 -0700 Greg KH wrote: > > > On Wed, Mar 16, 2011 at 06:52:39PM -0700, Greg KH wrote: > > > On Wed, Mar 16, 2011 at 05:34:08PM -0700, Linus Torvalds wrote: > > > > On Wed, Mar 16, 2011 at 5:32 PM, Linus Torvalds > > > > wrote: > > > > > > > > > > The one with inifinite errors was vt6655. > > > > > > > > vt6656 had same/similar issues. In fact, maybe it's simply because I > > > > built both of them in, and get infinite "multiple definitions" because > > > > they are the same driver with small differences? > > > > > > Ah, probably, if they are both built into the kernel that might happen > > > due to the global symbols in them. Actually that's odd, Randy's usual > > > 'randconfig' tester usually catches these, I'll make the Kconfig files > > > force them to be modules to keep this from happening in the future. > > > > Yes, that looks like the problem, as building them as modules in your > > tree right now works just fine. > > > > This patch below should solve your build issue, let me know if it > > doesn't. > > Thanks for the patch. You had suggested 1-2 months ago that someone do > this, so I was waiting to see if someone would actually do it. Ah, sorry about that, I forgot about it. > I was hoping that a staging developer would do it (not the staging > maintainer). Heh, well, these drivers are just "placeholders" as the "real" in-kernel drivers are being developed for this hardware, so I don't expect to see much, if any development happening on them. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/